-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate typeKey and replace with modelName #2874
Comments
When we move away from factories having concrete references to other factories and all API consume strings only. I think it is possible to stop polluting factories with a string name of any kind. This would finally let us fix the container and DI system which extends to shelter Ed from its factory polution |
I'm using this in production code to DRY up some actions. I would love for this to be a deprecation notice before giving it the axe. |
It will definitely be deprecated first. |
@igorT thank ya! ❤️ |
closed by #3033 |
modelName is a dasherized typeKey that we can be more rigorous about it being dasherized vs camelcased/snake cased/whatever.
This allows us to be more consistent in internals when accessing models via the container.
The text was updated successfully, but these errors were encountered: