Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate typeKey and replace with modelName #2874

Closed
fivetanley opened this issue Mar 13, 2015 · 5 comments
Closed

Deprecate typeKey and replace with modelName #2874

fivetanley opened this issue Mar 13, 2015 · 5 comments

Comments

@fivetanley
Copy link
Member

modelName is a dasherized typeKey that we can be more rigorous about it being dasherized vs camelcased/snake cased/whatever.

This allows us to be more consistent in internals when accessing models via the container.

@stefanpenner
Copy link
Member

When we move away from factories having concrete references to other factories and all API consume strings only. I think it is possible to stop polluting factories with a string name of any kind. This would finally let us fix the container and DI system which extends to shelter Ed from its factory polution

@tim-evans
Copy link
Contributor

I'm using this in production code to DRY up some actions. I would love for this to be a deprecation notice before giving it the axe.

@igorT
Copy link
Member

igorT commented Apr 19, 2015

It will definitely be deprecated first.

@tim-evans
Copy link
Contributor

@igorT thank ya! ❤️

@fivetanley
Copy link
Member Author

closed by #3033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants