Chained Ember.computed.filterBy properties fail for updated records

[webmonarch]

I have a controller that has two Ember.computed.filterBy properties. One depends on the output of the other. I've noticed that when data gets pushed in the store what changes the value that there filters operate on, I get incorrect results. If I manually code a computed property that delegates to Enumerable.filterBy it works as expected.

I've created a jsbin:

http://emberjs.jsbin.com/fesofu/5/edit

TO USE: click the tasks listed....I expect the two "Completed" counts to be the same. The "manually" computed value is correct but the other is incorrect.

[igorT]

cc @hjdivad

[webmonarch]

FWIW this issue is still in the latest beta 9.

I updated the jsbin: http://emberjs.jsbin.com/fesofu/8/edit

[sly7-7]

A first weird thing is if you use toggleProperty instead of push, it seems to work. see http://emberjs.jsbin.com/qexova/1/edit
A second weird thing is, in your example, if you click a second time on a task, then it appears in the 'automatic' filter. It's like it has the inverse value of completed.

[webmonarch]

@sly7-7 yeah, any changes that happen locally either through a property set or toggleProperty as mentioned works fine.

The reason my example uses Store.push is because it is what the ember-data adapter I am using (https://github.com/firebase/emberfire) does internally on remote updates to the data: https://github.com/firebase/emberfire/blob/b1fa49841642bc143e34f35fe7d38206f391faa3/src/data.js#L243

Yeah, I don't understand the behavior of Ember.computed.filterBy in this case...it's kinda the inverse AFTER an item has been toggled.

[wecc]

Probably related to emberjs/ember.js#5319 and emberjs/ember.js#5268

[RichardJohnn]

aye, I have been replacing Em.computed.filterBy uses with the hand written computed properties to work around this

[sly7-7]

I'm not sure if there is something to do in ember data for that case.
@igorT maybe we can close ?

[igorT]

I think this will be solved by the reduce computed removal in Ember

[wecc]

This seems fixed by emberjs/ember.js#11513, closing.