Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce deprecation warnings on beta/canary ember #55

Closed
tchak opened this issue Jul 3, 2020 · 5 comments
Closed

Introduce deprecation warnings on beta/canary ember #55

tchak opened this issue Jul 3, 2020 · 5 comments

Comments

@tchak
Copy link

tchak commented Jul 3, 2020

Since emberjs/ember.js#19025 this addon triggers deprecation warnings
@tchak tchak mentioned this issue Jul 3, 2020
Merged
@buschtoens
Copy link
Collaborator

Thanks for the heads up!

Form a quick glance, it looks like we could just start exposing the actual destroyable API from that version onward.

@rwjblue
Copy link
Member

rwjblue commented Jul 26, 2020

The deprecations on 3.20+ are fixed (as of #70), and just need a release.

@pzuraq / @buschtoens - Would you mind adding me to npm so I can release once the other changes I've got cookin' up are done?

@buschtoens
Copy link
Collaborator

Either @pzuraq already added you by now, or you've already been an owner. :)
image

@rwjblue
Copy link
Member

rwjblue commented Jul 27, 2020

Thank you @buschtoens (and @pzuraq)!

@rwjblue
Copy link
Member

rwjblue commented Jul 27, 2020

Resolved in https://github.com/ember-polyfills/ember-destroyable-polyfill/releases/tag/v1.0.0

@rwjblue rwjblue closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tchak @rwjblue @buschtoens