Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-diff +/- symbol renders outside of code block in first line #1956

Closed
fry69 opened this issue Aug 18, 2023 · 2 comments
Closed

data-diff +/- symbol renders outside of code block in first line #1956

fry69 opened this issue Aug 18, 2023 · 2 comments

Comments

@fry69
Copy link

fry69 commented Aug 18, 2023

I am currently on my way through the tutorial and noticed that if the first line of a code block is subject to change, the +/- renders outside the code block, see attached images. I tested this with current Safari (16.6) and Firefox (116.0.3). The images are from Safari from the following two URLs

https://guides.emberjs.com/release/tutorial/part-2/service-injection/#toc_splattributes-and-the-class-attribute

misplaced minus symbol

https://guides.emberjs.com/release/tutorial/part-2/service-injection/#toc_the-router-service

misplaced plus symbol

Searching for a prior I did not find any other bug mentioning this, also the data-diff arguments seem to be correct, so it must be bug in the highlighting code, but I have to clue where to look for this.

Tiny plug: I stumbled over #1534 and would love to see a before/after/diff view rather than this +/- view only.

@fry69
Copy link
Author

fry69 commented Aug 22, 2023

Fix for this bug was merged into ember-showdown-prism. This issue can be closed when the fix arrives here.

@fry69
Copy link
Author

fry69 commented Oct 31, 2023

Seems fixed, great. Closing.

@fry69 fry69 closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant