Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API reference rendering bug #7

Closed
samselikoff opened this issue Jul 1, 2017 · 4 comments
Closed

API reference rendering bug #7

samselikoff opened this issue Jul 1, 2017 · 4 comments

Comments

@samselikoff
Copy link
Contributor

samselikoff commented Jul 1, 2017

If you visit /docs/api you'll see I have some of the text form the components. Right now the data is rendered using double curlies. When I try to render as HTML using triple curlies {{{ }}}, the rendering isn't cleaned up as I navigate around the app.

After we figure this out I can go back to designing out these pages a bit more and making some useful components for people to use.

@samselikoff
Copy link
Contributor Author

For some reason I was unable to reproduce with same dependencies in an app without the API doc json generator, maybe someone else can give it a try

@dfreeman
Copy link
Contributor

dfreeman commented Jul 3, 2017

It looks like the bug doesn't strike with double curlies and htmlSafe strings, so we could just work around this for now by rendering an HTML-safe version of the description string (or even something gnarly like an html transform for that model attr, as a super quick fix)

Edit: actually, just wrapping in <div> to give the mustache a concrete anchor seems to solve the problem locally, at least

@samselikoff
Copy link
Contributor Author

@dfreeman nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants