Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation for Component#isVisible in 3.x #321

Closed
jayjayjpg opened this issue Apr 11, 2019 · 2 comments
Closed

Add deprecation for Component#isVisible in 3.x #321

jayjayjpg opened this issue Apr 11, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jayjayjpg
Copy link
Contributor

Please add a descriptive deprecation message to the application explaining the upcoming removal of Component#isVisible from the API.

Please show how users can migrate away from the usage of isVisible in their app according to the How we teach this section from the original RFC with a before & after code example:

Part of emberjs/rfc-tracking#22
@kategengler kategengler mentioned this issue Apr 11, 2019
Closed
6 tasks
@kennethlarsen kennethlarsen added the good first issue Good for newcomers label Jul 5, 2019
@kennethlarsen
Copy link
Member

If anyone wants to pick this up I'll happily pair with you.

@kennethlarsen kennethlarsen added the help wanted Extra attention is needed label Jul 5, 2019
@jaredgalanis jaredgalanis removed their assignment Mar 6, 2020
@jaredgalanis
Copy link
Member

Closed by #536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennethlarsen @jaredgalanis @jayjayjpg