From 3171cf85ec6db8c1ac67ab7fc1bd6a5f3fb36de7 Mon Sep 17 00:00:00 2001 From: Bryan Mishkin <698306+bmish@users.noreply.github.com> Date: Mon, 7 Sep 2020 16:57:08 -0400 Subject: [PATCH] breaking: add ESLint 6+ as peer dependency and drop ESLint 5 support --- .github/workflows/ci.yml | 1 - README.md | 2 +- lib/utils/traverser.js | 4 ++-- package.json | 3 +++ 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2fc90f1587..4c0c90d110 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,5 +28,4 @@ jobs: - run: yarn lint - run: yarn update && git diff --exit-code - run: yarn test:coverage --runInBand - - run: yarn add --dev eslint@5 && yarn test --runInBand - run: yarn add --dev eslint@6 && yarn test --runInBand diff --git a/README.md b/README.md index 1f4ae379f2..14a954c9b2 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ ## ❗️Requirements -- [ESLint](https://eslint.org/) `>= 5` +- [ESLint](https://eslint.org/) `>= 6` - [Node.js](https://nodejs.org/) `10.* || 12.* || >= 14` ## 🚀 Usage diff --git a/lib/utils/traverser.js b/lib/utils/traverser.js index ab5e2aaed8..4069878c63 100644 --- a/lib/utils/traverser.js +++ b/lib/utils/traverser.js @@ -2,13 +2,13 @@ module.exports = getTraverser; +/* eslint node/no-unpublished-require:"off", node/no-missing-require:"off" */ + function getTraverser() { let traverser; try { - // eslint-disable-next-line node/no-unpublished-require traverser = require('eslint/lib/shared/traverser'); // eslint >= 6 } catch { - // eslint-disable-next-line node/no-unpublished-require, node/no-missing-require traverser = require('eslint/lib/util/traverser'); // eslint < 6 } return traverser; diff --git a/package.json b/package.json index e395ea5a84..a7fbeaa30b 100644 --- a/package.json +++ b/package.json @@ -37,6 +37,9 @@ "engines": { "node": "10.* || 12.* || >= 14" }, + "peerDependencies": { + "eslint": ">= 6" + }, "license": "MIT", "bugs": { "url": "https://github.com/ember-cli/eslint-plugin-ember/issues"