Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing fastboot dependencies whitelist entry. #113

Merged
merged 1 commit into from
May 18, 2018

Conversation

CvX
Copy link
Contributor

@CvX CvX commented May 18, 2018

Fixes an error (introduced in #112) that occurs whenever a fastboot-enabled app that uses ember-fetch tries to handle a request:

There was an error running your app in fastboot. More info about the error:
 Error: Unable to require module 'abortcontroller-polyfill/dist/cjs-ponyfill' because it was not in the whitelist.
    at Object.require (/app/node_modules/fastboot/src/ember-app.js:133:15)
    at Module.callback (/app/tmp/broccoli_merge_trees-output_path-76mgNO0Y.tmp/ember-fetch/fastboot-fetch.js:4:44)

package.json Outdated
@@ -58,7 +58,8 @@
"configPath": "tests/dummy/config",
"fastbootDependencies": [
"node-fetch",
"abortcontroller-polyfill"
"abortcontroller-polyfill",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to delete this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Changed, tested, and updated the PR. Thanks!

@CvX CvX force-pushed the fix-fastboot-whitelist branch from aa91257 to f4ed8d0 Compare May 18, 2018 14:34
@xg-wang xg-wang merged commit 78e2691 into ember-cli:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants