Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation for ember data mixin for older ED versions #391

Closed
mydea opened this issue Nov 18, 2019 · 3 comments
Closed

Deprecation for ember data mixin for older ED versions #391

mydea opened this issue Nov 18, 2019 · 3 comments
Labels

Comments

@mydea
Copy link
Contributor

mydea commented Nov 18, 2019

After #308, we get a lot of deprecation warnings in our app:

DEPRECATION: FetchAdapter is deprecated, it is no longer required for ember-data>=3.9.2 [deprecation id: deprecate-fetch-ember-data-support]

We cannot easily update ED (for other reasons), so we are currently using 3.4.x.

The deprecation warning incorrectly suggests that we should stop using the FetchAdapter. I guess the deprecation should only be shown for users with ember-data >= 3.10?

@Turbo87
Copy link
Member

Turbo87 commented Dec 20, 2019

I'm seeing the same issue on https://github.com/rust-lang/crates.io

/cc @xg-wang

@xg-wang
Copy link
Member

xg-wang commented Feb 19, 2020

@stefanpenner #447 will be contradicting the request here to only log deprecation for newer ember-data versions. If we're going to drop the mixin, answer to this issue is to manually silence the deprecation until ember-data upgrade is finished.

@mydea @Turbo87 what do you think?

@mydea
Copy link
Contributor Author

mydea commented Feb 19, 2020

I guess that's OK, maybe not ideal but workable!

@xg-wang xg-wang closed this as completed Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants