Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Getting DS is not defined #26

Closed
bj-mcduck opened this issue Jul 3, 2015 · 11 comments
Closed

Getting DS is not defined #26

bj-mcduck opened this issue Jul 3, 2015 · 11 comments
Labels

Comments

@bj-mcduck
Copy link

I'm getting this error from ember-cli-shims/app-shims.js:

Uncaught ReferenceError: DS is not defined
    at eval (eval at evaluate (unknown source), <anonymous>:1:1)
    at Object.InjectedScript._evaluateOn (<anonymous>:895:55)
    at Object.InjectedScript._evaluateAndWrap (<anonymous>:828:34)
    at Object.InjectedScript.evaluateOnCallFrame (<anonymous>:954:21)
    at http://localhost:4200/agent/assets/vendor.js:67613:3
    at mod.state (http://localhost:4200/agent/assets/vendor.js:150:29)
    at tryFinally (http://localhost:4200/agent/assets/vendor.js:30:14)
    at requireModule (http://localhost:4200/agent/assets/vendor.js:148:5)
    at requireFrom (http://localhost:4200/agent/assets/vendor.js:121:12)
    at reify (http://localhost:4200/agent/assets/vendor.js:106:22)

I'm on Ember 1.13.2, and Ember Data 1.13.4, and Ember CLI 0.2.7.

@stefanpenner
Copy link
Contributor

i believe this is fixed on the #canary branch: https://github.com/ember-cli/ember-cli-shims/tree/canary

Can you try?

@bj-mcduck
Copy link
Author

Absolutely! Thanks.

@bj-mcduck
Copy link
Author

Ya, I think that did it. Thanks very much! You are greased lightning!

@bj-mcduck
Copy link
Author

giphy

@stefanpenner
Copy link
Contributor

@tomdale is #canary ready for mainline? I believe you where planning on shipping it once it was. Let me know if i need to unblock you.

@rwjblue
Copy link
Member

rwjblue commented Jul 3, 2015

@stefanpenner - Yes, I believe that it is ready.

@stefanpenner
Copy link
Contributor

its still only in canary. Let see if @tomdale can shed some light, maybe it isn't quite ready?

@stefanpenner stefanpenner reopened this Jul 3, 2015
@tomdale
Copy link
Contributor

tomdale commented Jul 6, 2015

Merged

@tomdale tomdale closed this as completed Jul 6, 2015
@bj-mcduck
Copy link
Author

So is this in a release now? Or should I just point to master for now?

@tomdale
Copy link
Contributor

tomdale commented Jul 8, 2015

@brandonjmckay We have not done a release yet. We probably need to reach consensus in emberjs/rfcs#68 before doing an initial release. master should be good for now.

@bj-mcduck
Copy link
Author

Many thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants