Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot call currentURL middleware reporter error #513

Closed
drewlee opened this issue Aug 9, 2023 · 1 comment
Closed

Cannot call currentURL middleware reporter error #513

drewlee opened this issue Aug 9, 2023 · 1 comment
Labels

Comments

@drewlee
Copy link
Contributor

drewlee commented Aug 9, 2023

Running ember-a11y-testing using the middleware reporter results in a precedent of tests failing with the Cannot call 'currentURL' error.

Cannot call `currentURL` without having first called `setupApplicationContext`."Source:
Error: Cannot call `currentURL` without having first called `setupApplicationContext`.
    at currentURL (https://localhost:4444/assets/test-support.js:21927:13)
    at middlewareReporter (https://localhost:4444/assets/test-support.js:31356:49)
    at async https://localhost:4444/assets/test-support.js:31289:11...

The exact reason is uncertain, as audits are invoked after setupApplicationTests is called. However, we should probably have better insulation where currentURL is called so that the entire test doesn't fall over when this error is encountered.

@drewlee
Copy link
Contributor Author

drewlee commented Aug 25, 2023

Fixed and released v6.1.1 via PR #514 .

@drewlee drewlee closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant