Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to npm-run-all2 causing issues #380

Closed
MelSumner opened this issue Jul 30, 2024 · 1 comment · Fixed by #390
Closed

Update to npm-run-all2 causing issues #380

MelSumner opened this issue Jul 30, 2024 · 1 comment · Fixed by #390
Labels
help wanted Extra attention is needed

Comments

@MelSumner
Copy link
Member

MelSumner commented Jul 30, 2024

This PR: #368 had tests passing, so I felt safe to merge it. However, I think this needs a bit more investigation.

  1. after merging, I was getting npm-run-all not found error messages when I pulled the main branch down locally and ran pnpm start.
  2. I thought it was just related to the package.json scripts, but even after updating them to use npm-run-all2 instead of npm-run-all, I was still getting the error message when running pnpm start
  3. I reinstalled npm-run-all as a devdep, just in case it's something an Ember script needed (leaving the package.json updated)
  4. Everything builds and tests run locally, but were failing in the PR (tests run via GitHub action)

Since I don't see anything in the action right now, I've changed the scripts in package.json back to the way they were (using npm-run-all), but am leaving both devdeps there for the time being.

Want to help figure out what's going on? Help is welcome!

@MelSumner MelSumner added the help wanted Extra attention is needed label Jul 30, 2024
@aklkv
Copy link
Contributor

aklkv commented Jan 10, 2025

will be fixed in #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants