-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationale: Marking #19
Comments
One solution is that in normal mode:
And in visual mode
|
It'll probably be good to include the current rationale in this thread as the readme will probably evolve indepedent of this thread. I think 'u' for unmarking fits pretty well. I'm not sure there's a mode where you have both an unmark and an undo action. |
Some of the keymap from dired and ibuffer around marking. |
Current rationale
|
@Somelauw: I like your suggestion. Rationale: toggle is more often needed than one-way commands. It also means that the mark commands should be "mark and forward-line" readlly, so that we can press, say, |
With that in mind, it means that many bindings are overlapping. Which is fine, but we don't want to consume too many keys either, lest we will conflict with more modes. Suggestion:
Then Next question: I think we should leave |
Bonus of the former: this frees back |
'#' being free is important as it's a useful 'movement' key (then again * would be taken which is also a useful key to move around in (that's regrettable..)). I wonder a little if we should move these common mark actions to a prefix instead (m for example). mm: mark That frees up '#', '*', 'u', etc at the cost of becoming slightly 'prefix heavy'. Thoughts? @Somelauw @Ambrevar I'm okay with your suggestion by the way. Food for thought is my comment. |
@Somelauw was against this for evil-org-agenda: his point was they are high frequency bindings, and as such they should be as short as possible (i.e. only one character). A middle ground could also be possible:
I have no clue what key would be a great prefix. Maybe |
Lets go with your initial suggestion then, losing * isn't that bad. Reposting it for clarity. Suggestion:
Then # is free and so is U, probably. Next question: I think we should leave x to the modes. If * is taken for "mark prefix", what about using # for "execute action on mark"? |
See #96. |
The rationale has now some idea about marking.
It's not clear yet if we should ignore
u
orU
to unmark, since most modes supporting marking do not support "undoing actions".It's not clear either whether the marking bindings should be togglers and whether they should work on regions. I like the idea of regions though.
The text was updated successfully, but these errors were encountered: