Allow disabling refresh on tab focus

[KaKi87]

Hello,

I often do the following :

• browse a feed ;
• open a post in new background tab ;
• continue browsing feed ;
• focus post tab.

What I expect is : being able to read the post immediately.

What I experience is : needing to wait for the page to refresh while it already had plenty of time to load in the first place.

Please allow disabling this behavior.

Thanks

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

[HawtinZeng]

Sorry, bro, I don't understand what is your problem, can u give me more explanations or offer some video to demonstrate your problem?

[KaKi87]

Exactly like I said :

[KaKi87]

Hello,
Any news on this ?
Thanks

[userquin]

I'm going to check the page lifecycle, it seems browsers freeze/discard tabs aggresively or we've a bug in the logic.

We need to control those events to close all indexed db connections and control user account switch:
https://developer.chrome.com/docs/web-platform/page-lifecycle-api

[KaKi87]

browsers freeze/discard tabs aggresively

Nope.

or we've a bug

Or a feature. But I just want the ability to disable it.

Thanks

[userquin]

browsers freeze/discard tabs aggresively

Nope.

From the page lifecycle, Frozen state in the table:

In particular, it's important that you:

• Close all open IndexedDB connections.
• Close open BroadcastChannel connections.
• Close active WebRTC connections.
• Stop any network polling or close any open Web Socket connections.
• Release any held Web Locks.

and some more inputs:

For the moment, Chrome is going to be conservative when discarding pages and only do so when it's confident it won't affect users. For example, pages that have been observed to do any of the following while in the hidden state will not be discarded unless under extreme resource constraints:

• Playing audio
• Using WebRTC
• Updating the table title or favicon
• Showing alerts
• Sending push notifications

and from unload event, maybe we need to include some protection with the persisted event prop:

const terminationEvent = 'onpagehide' in self ? 'pagehide' : 'unload';
window.addEventListener(terminationEvent, (event) => {
// Note: if the browser is able to cache the page, event.persisted
// is true, and the state is frozen rather than terminated.
});

[KaKi87]

I assure you it's none of that.

But in the meantime, I noticed that installing the Disable Page Visibility API extension is a workaround that disables this behavior.

So I went after related listeners and found this :

elk/composables/users.ts

Line 102 in 1ff1395

window.addEventListener('visibilitychange', windowReload, { capture: true })

I'm pretty sure this is it.

[userquin]

So I went after related listeners and found this :

The listener is added on demand and only when the account changes: keeping both tabs in sync (it is inside a watcher).

This issue seems to be about loading the new page content, the problem here is the tab visibility, there are some useAsyncData forced to reload the data when page is hydrated and reactivated (we've keep alive), I'm checking if we can fix this.

My previous comments was about switching tabs, from time to time there is a page reload, releted to page lifecycle plugin logic, sorry for the noise.

[HawtinZeng]

Maybe the refreshed tab is triggered by this hook in [status].vue and index.vue component.

onReactivated(() => {
  // Silently update data when reentering the page
  // The user will see the previous content first, and any changes will be updated to the UI when the request is completed
  refreshStatus()
  refreshContext()
})

[jyn514]

The listener is added on demand and only when the account changes: keeping both tabs in sync (it is inside a watcher).

this is not true, it also is added on the first login. i tested and signing out of Elk makes the bug go away (i.e. switching back to the tab becomes instant).

maybe you intended to reload only when the user is changed, not each time the tab gains or loses focus? i can make a PR with that change.

[userquin]

There is a bug in 0.15.0 version, should be fixed in main elk.zone, we need a new release to fix the page refresh.

[jyn514]

There is a bug in 0.15.0 version, should be fixed in main elk.zone, we need a new release to fix the page refresh.

hmm, i am also seeing the bug in my local copy of elk.zone built from 54344ac.

[jyn514]

oh i see, you just merged a fix 8 hours ago. yes, with that branch the bug is fixed :) sorry for the noise

[shuuji3]

We released v0.15.1 and it should be available at https://elk.zone/. The new version includes some reloading issue fixes by #2975.