Implement suggestions by @wojtekmach

Author: eksperimental

lib/ex_doc/autolink.ex

@@ -479,11 +479,12 @@ defmodule ExDoc.Autolink do
       {:type, :hidden} ->
         nil
 
-      _ ->
-        unless kind == :type and name in [:required, :optional] and arity == 1 do
-          maybe_warn(ref, config, visibility, %{original_text: original_text})
-        end
+      # skip `@type %{required(...), optional(...), ...}`
+      {:type, _visibility} when name in [:required, :optional] and arity == 1 ->
+        nil
 
+      _ ->
+        maybe_warn(ref, config, visibility, %{original_text: original_text})
         nil
     end
   end
@@ -506,7 +507,7 @@ defmodule ExDoc.Autolink do
             nil
 
           tool ->
-            if module == config.current_module do
+            if same_module? do
               fragment(tool, kind, name, arity)
             else
               app_module_url(tool, module, config) <> fragment(tool, kind, name, arity)

lib/ex_doc/refs.ex

@@ -123,7 +123,7 @@ defmodule ExDoc.Refs do
         if Code.ensure_loaded?(module) do
           (to_refs(exports(module), module, :function) ++
              to_refs(callbacks(module), module, :callback) ++
-             to_refs(types(module), module, :type) ++
+             to_refs(types(module, [:type, :opaque]), module, :type) ++
              to_refs(types(module, [:typep]), module, :type, :hidden))
           |> Enum.concat([{{:module, module}, :public}])
         else
@@ -155,7 +155,7 @@ defmodule ExDoc.Refs do
     end
   end
 
-  defp types(module, kind_list \\ [:type, :opaque]) do
+  defp types(module, kind_list) do
     case Code.Typespec.fetch_types(module) do
       {:ok, list} ->
         for {kind, {name, _, args}} <- list,

test/mix/tasks/docs_test.exs

@@ -82,7 +82,8 @@ defmodule Mix.Tasks.DocsTest do
            ] = run([], app: :ex_doc, docs: [])
 
     assert List.keyfind(deps, :earmark_parser, 0) ==
-             {:earmark_parser, "https://hexdocs.pm/earmark_parser/#{Application.spec(:earmark_parser, :vsn)}/"}
+             {:earmark_parser,
+              "https://hexdocs.pm/earmark_parser/#{Application.spec(:earmark_parser, :vsn)}/"}
   end
 
   test "allows custom dependency paths" do