Speed up sliding sync by avoiding copies #17670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ended up spending ~10% CPU creating a new dictionary and `_RoomMembershipForUser`, so let's avoid creating new dicts and copying by returning `newly_joined`, `newly_left` and `is_dm` as sets directly.
MadLittleMods
approved these changes
Sep 5, 2024
| @@ -519,7 +524,7 @@ async def get_room_sync_data( | |||
| from_bound = None | |||
| initial = True | |||
| ignore_timeline_bound = False | |||
| if from_token and not room_membership_for_user_at_to_token.newly_joined: | |||
There was a problem hiding this comment.
We can remove this logic because we're just going to rely on HaveSentRoomFlag.NEVER?
We should update the comment above
There was a problem hiding this comment.
Yeah, oops sorry. Having thought about this some more we probably want to keep this flag (in the case where people join / leave / join).
Co-authored-by: Eric Eastwood <[email protected]>
Co-authored-by: Eric Eastwood <[email protected]>
Co-authored-by: Eric Eastwood <[email protected]>
erikjohnston
force-pushed
the
erikj/ss_avoid_copies
branch
from
333268a to
91f2591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended up spending ~10% CPU creating a new dictionary and
_RoomMembershipForUser, so let's avoid creating new dicts and copying by returningnewly_joined,newly_leftandis_dmas sets directly.