Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local echo for new room picture isn't there #921

Closed
kittykat opened this issue Jul 19, 2023 · 4 comments · Fixed by #2197
Closed

Local echo for new room picture isn't there #921

kittykat opened this issue Jul 19, 2023 · 4 comments · Fixed by #2197
Assignees
@jmartinesp
Labels
A-Room-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish

Comments

@kittykat
Copy link
Contributor

Steps to reproduce

  1. Go to a room where you are admin
  2. Change the room avatar
  3. Save

Outcome

What did you expect?

I see a local echo of the room avatar when I land back in the room detail view after saving the new photo

What happened instead?

I still see a blank picture (there was no room avatar before)

Your phone model

Pixel 6a

Operating system version

Graphene OS

Application version and app store

Nightly

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

No
@kittykat kittykat added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 19, 2023
@julioromano julioromano added A-Room-Detail S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 7, 2023
@bmarty
Copy link
Member

bmarty commented Sep 7, 2023

Should be possible now that we have matrix-org/matrix-rust-sdk#2411

@jplatte
Copy link
Contributor

jplatte commented Sep 14, 2023

Well, not so easy. It's the same thing as sending media, we can't have a local echo before the image is uploaded. This will be fixed by the async upload MSC (Synapse PR still pending merge).

@VolkerJunginger
Copy link

It does not need to be a "local echo". There is already an update of the room happening and the picture has been uploaded. The Android App just deos not update the room-detail screen.

@jmartinesp jmartinesp self-assigned this Jan 9, 2024
@jmartinesp jmartinesp mentioned this issue Jan 9, 2024
Merged
14 tasks
@jplatte
Copy link
Contributor

jplatte commented Jan 9, 2024

FWIW, asynchronous uploads (which were blocking proper local echoes for media) are shipping in Synapse v1.97.0+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
A-Room-Detail O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the room settings screen update automatically element-hq/element-x-android
7 participants
@kittykat @jmartinesp @jplatte @julioromano @bmarty @manuroe @VolkerJunginger