Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the SDK manage the file log cleanup, and keep one week of log. #2758

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 26, 2024

No description provided.

@bmarty bmarty requested a review from a team as a code owner April 26, 2024 10:35
@bmarty bmarty requested review from jmartinesp and removed request for a team April 26, 2024 10:35
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Z9rpKv

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.60%. Comparing base (ba1f21c) to head (1a2a9ac).

Files Patch % Lines
...es/matrix/api/tracing/WriteToFilesConfiguration.kt 0.00% 5 Missing ⚠️
...lement/android/x/initializer/TracingInitializer.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2758      +/-   ##
===========================================
- Coverage    73.60%   73.60%   -0.01%     
===========================================
  Files         1504     1504              
  Lines        36060    36058       -2     
  Branches      6958     6957       -1     
===========================================
- Hits         26541    26539       -2     
  Misses        5870     5870              
  Partials      3649     3649              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 26, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Apr 26, 2024
@bmarty bmarty enabled auto-merge April 26, 2024 14:52
@bmarty bmarty merged commit 27b91c2 into develop Apr 26, 2024
17 of 19 checks passed
@bmarty bmarty deleted the feature/bma/logRotation branch April 26, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants