Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show new name just once, not twice in display name change events #2125

Closed
rom4nik opened this issue Dec 28, 2023 · 0 comments · Fixed by #2545
Closed

Show new name just once, not twice in display name change events #2125

rom4nik opened this issue Dec 28, 2023 · 0 comments · Fixed by #2545
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Issue needs input from Product team

Comments

@rom4nik
Copy link
Contributor

rom4nik commented Dec 28, 2023

Your use case

What would you like to do?

See issue title.

Why would you like to do it?

It looks quite confusing at first glance, especially with long names that include sentences or away text:
Screenshot_20230927-125549_Element X

How would you like to achieve it?

I think it would be sufficient to change the string like so: $old_name changed their display name to $new_name.

Have you considered any alternatives?

I don't see anything better than simply showing old -> new instead of what's right now.

Additional context

Maybe it'd be nicer for readability if the display names in that event were somehow highlighted, or just looked different than the changed their display name text, especially with long names like in screenshot above.

Are you willing to provide a PR?

Yes
@rom4nik rom4nik added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Dec 28, 2023
@jmartinesp jmartinesp added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience X-Needs-Product Issue needs input from Product team labels Dec 29, 2023
@jmartinesp jmartinesp mentioned this issue Mar 13, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Issue needs input from Product team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use userId on display name change state events element-hq/element-x-android
2 participants
@jmartinesp @rom4nik