-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rich text editor] Ensure keyboard opens for reply and text formatting modes #1337
Conversation
aeacc10
to
913830f
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
913830f
to
bf7a72a
Compare
bf7a72a
to
4933edb
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1337 +/- ##
===========================================
- Coverage 57.91% 57.91% -0.01%
===========================================
Files 1109 1110 +1
Lines 29256 29270 +14
Branches 5976 5979 +3
===========================================
+ Hits 16945 16953 +8
- Misses 9683 9685 +2
- Partials 2628 2632 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some Kdoc to update.
Kudos, SonarCloud Quality Gate passed!
|
Type of change
Content
Ensure keyboard opens for reply and text formatting modes.
Note that it doesn't seem possible to use
LocalSoftwareKeyboardController
to control the keyboard when the focused UI is anAndroidView
.Motivation and context
Screenshots / GIFs
Screen_recording_20230914_185152.webm
Tests
Close keyboard
Reply to a message
Check keyboard is open
Close keyboard
Open text formatting menu
Check keyboard is open
Tested devices
Checklist