Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich text editor] Ensure keyboard opens for reply and text formatting modes #1337

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Sep 14, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure keyboard opens for reply and text formatting modes.

Note that it doesn't seem possible to use LocalSoftwareKeyboardController to control the keyboard when the focused UI is an AndroidView.

Motivation and context

Screenshots / GIFs

Screen_recording_20230914_185152.webm

Tests

  • Close keyboard

  • Reply to a message

  • Check keyboard is open

  • Close keyboard

  • Open text formatting menu

  • Check keyboard is open

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XkEf1u

@jonnyandrew jonnyandrew force-pushed the jonny/rte-focus-and-keyboard branch from 913830f to bf7a72a Compare September 14, 2023 18:28
@jonnyandrew jonnyandrew force-pushed the jonny/rte-focus-and-keyboard branch from bf7a72a to 4933edb Compare September 14, 2023 18:30
@jonnyandrew jonnyandrew marked this pull request as ready for review September 15, 2023 10:17
@jonnyandrew jonnyandrew requested a review from a team as a code owner September 15, 2023 10:17
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team September 15, 2023 10:17
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: -0.01% ⚠️

Comparison is base (6563dca) 57.91% compared to head (68b8db7) 57.91%.
Report is 22 commits behind head on develop.

❗ Current head 68b8db7 differs from pull request most recent head 3663eab. Consider uploading reports for the commit 3663eab to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1337      +/-   ##
===========================================
- Coverage    57.91%   57.91%   -0.01%     
===========================================
  Files         1109     1110       +1     
  Lines        29256    29270      +14     
  Branches      5976     5979       +3     
===========================================
+ Hits         16945    16953       +8     
- Misses        9683     9685       +2     
- Partials      2628     2632       +4     
Files Changed Coverage Δ
.../element/android/libraries/androidutils/ui/View.kt 17.39% <27.27%> (+17.39%) ⬆️
...droid/libraries/textcomposer/SoftKeyboardEffect.kt 75.00% <75.00%> (ø)
...ent/android/libraries/textcomposer/TextComposer.kt 54.67% <100.00%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some Kdoc to update.

@jonnyandrew jonnyandrew enabled auto-merge (squash) September 16, 2023 07:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonnyandrew jonnyandrew merged commit 519464f into develop Sep 16, 2023
@jonnyandrew jonnyandrew deleted the jonny/rte-focus-and-keyboard branch September 16, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants