[Compound] implement IconButton changes #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Kudos, SonarCloud Quality Gate passed! |
jmartinesp
requested review from
a team and
ganfra
and removed request for
bmarty and
a team
ganfra
approved these changes
Aug 11, 2023
| @@ -36,11 +42,15 @@ fun IconButton( | |||
| interactionSource: MutableInteractionSource = remember { MutableInteractionSource() }, | |||
| content: @Composable () -> Unit | |||
| ) { | |||
| val colors = IconButtonDefaults.iconButtonColors( | |||
| contentColor = LocalContentColor.current, | |||
There was a problem hiding this comment.
Why are we using LocalContentColor here and ElementTheme.colors for disabled?
There was a problem hiding this comment.
The way it was designed in Figma, the icon button could use either primary or secondary colors, so it made more sense to just allow the parent component to decide which color should be used for the icon.
As for disabled state, it's always the same color for icons, so we can just hardcode it.
jmartinesp
deleted the
chore/jme/compound-platform-components-iconbutton
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
LocalContentColorfor tinting.