-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to peek into invites #807
Comments
@AmandineLP any idea what flow they were trying to use to peek? |
I just reproduced it on /beta clicking on the invite. I just get the "would you like to accept or decline the invite" msg. but I cna't see history despite the room being peekable. |
So we deliberately don't let people peek into invites yet. We do let people peek when they explicitly join rooms, but given the problems we're seeing there I'd like to get that stable first before we open up a whole new level of complexity with this. Going to bump it to v1. The relevant code is: |
...and bumping this to v2... |
actually, this is harder than I recalled as it requires server-side stuff. We can't currently peek into arbitrary invites because we're not yet joined to the room(!) |
filed as SPEC-368 |
This would also stop us having send invite stale metadata snapshots around the place for name/alias/avatar etc, as we can preview the correct live metadata for the room. |
Wow, seems some improvement happens with this issue: matrix-org/matrix-react-sdk@f0333b5 🚀 |
@MurzNN nope, that is an explicit invite reason as specified by the inviter, not the ability to peek into the room. |
Closing in favor of element-hq/element-meta#230 which suggests a "Preview" button to avoid being shown spam from an unwanted invite. |
I invited a user already registered using his email and later his matrix ID but he couldn't peek despite the setting being turned on
The text was updated successfully, but these errors were encountered: