Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain theme settings after logout/in #22021

Open
tmissoni opened this issue May 2, 2022 · 7 comments
Open

Maintain theme settings after logout/in #22021

tmissoni opened this issue May 2, 2022 · 7 comments
Labels
A-Theming A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@tmissoni
Copy link

tmissoni commented May 2, 2022

Your use case

What would you like to do?

Settings of custom theme on Element Web Browser are not kept after logout/login.
Such settings should be kept and store as part of user settings

Why would you like to do it?

UX is poor in this situations. My clients should inherit such settings

Have you considered any alternatives?

No response

Additional context

This has been pointed out during the PoC of Hessen, potentially a huge deal.

@duxovni duxovni added S-Minor Impairs non-critical functionality or suitable workarounds exist A-User-Settings A-Theming O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 2, 2022
@duxovni duxovni changed the title Maintain setting after logout/in Maintain theme settings after logout/in May 2, 2022
@turt2live turt2live added the X-Needs-Product More input needed from the Product team label May 2, 2022
@t3chguy
Copy link
Member

t3chguy commented May 2, 2022

It used to be set at the account level, then product decided for it to be device specific - matrix-org/matrix-react-sdk#4810 is the context

@nadonomy
Copy link
Contributor

nadonomy commented May 12, 2022

We made the change from account wide to device specific as it presented problems for multi-desktop users— e.g. different desktop environments for the same user might demand different text size settings. Per device also removes any sync nasties or expectations from the equation.

I think there's some nuance needed to find the right path.

@tmissoni few q's to help:

  1. Specifically which display/theme settings are you expecting to persist?
  2. Can you describe the user lifecycle in more detail (e.g. is it users logging in to the same web browser continually? or different computers?)
  3. Will the PoC be using Element Web on app.element.io or a custom/EMS deployment?

@tmissoni
Copy link
Author

tmissoni commented May 12, 2022

I understand the use case but if I login from another browser/desktop I would honestly expect to have my configuration, or at least decide if I want to have sync config or per/device config
1 - Imo we should keep clients settings consistent if I login from another platform. And I mean everything, from notifications, to appearance, to keyboard (keyboard not due to different key layout). This is valid both for web or desktop, because it will also be unlikely that people uses both on the same machine.
2 - users are likely to login from different computers, due to the fact that such resources are shared. It is then very annoying to go through the settings again.
3 - PoC is running on a custom on-premise installation, together with Element Web

@t3chguy
Copy link
Member

t3chguy commented May 12, 2022

to keyboard

This doesn't scale well, if a user has both Mac & non-mac, or different keyboard layouts.

@tmissoni
Copy link
Author

Agreed on the keyboard. This could be omitted

@nadonomy
Copy link
Contributor

1 - Imo we should keep clients settings consistent if I login from another platform. And I mean everything, from notifications, to appearance, to keyboard. This is valid both for web or desktop, because it will also be unlikely that people uses both on the same machine.

This is a pretty large blanket statement. We need to break it down to be able to figure out a productive path. As @t3chguy said keyboards don't scale, notifications also don't scale as browsers sandbox permissions, browsers vs desktop have different constraints on what data we can persist, etc.

Can you be more specific on what things the PoC is expecting to persist? A list of specific, exact settings which are blocking known user needs would be the most useful. with a rationale on why.

2 - users are likely to login from different computers, due to the fact that such resources are shared. It is then very annoying to go through the settings again.
3 - PoC is running on a custom on-premise installation, together with Element Web

For Element Web/our production deployments we generally optimise our decision making for individuals (1) continually using their personal computers (2) logging in to web browsers ephemerally. Depending on the answers to the above we might be able to tweak the default behaviours, or might need to extend our capabilities for custom deployments.

@tmissoni
Copy link
Author

1 - Imo we should keep clients settings consistent if I login from another platform. And I mean everything, from notifications, to appearance, to keyboard. This is valid both for web or desktop, because it will also be unlikely that people uses both on the same machine.

This is a pretty large blanket statement. We need to break it down to be able to figure out a productive path. As @t3chguy said keyboards don't scale, notifications also don't scale as browsers sandbox permissions, browsers vs desktop have different constraints on what data we can persist, etc.

Can you be more specific on what things the PoC is expecting to persist? A list of specific, exact settings which are blocking known user needs would be the most useful. with a rationale on why.
I will define 2-3 blocks of settings that makes sense to be inherited between different logins

2 - users are likely to login from different computers, due to the fact that such resources are shared. It is then very annoying to go through the settings again.
3 - PoC is running on a custom on-premise installation, together with Element Web

For Element Web/our production deployments we generally optimise our decision making for individuals (1) continually using their personal computers (2) logging in to web browsers ephemerally. Depending on the answers to the above we might be able to tweak the default behaviours, or might need to extend our capabilities for custom deployments.

I guess here we can really intend this to be on custom/on-premise deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Theming A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

5 participants