Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsupported redaction reasons #17246

Open
HarHarLinks opened this issue May 11, 2021 · 4 comments
Open

Remove unsupported redaction reasons #17246

HarHarLinks opened this issue May 11, 2021 · 4 comments
Labels
A-Redaction O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@HarHarLinks
Copy link
Contributor

HarHarLinks commented May 11, 2021 •
edited
Loading

Description

Redaction reasons are currently not supported in order to avoid abuse #17241, matrix-org/matrix-react-sdk#5604.
The fact that Element still offers the input field is confusing and, in my eyes, a defect.
Especially, the reason is still saved and shown when viewing hidden events.

Add the feature to the backlog and move it behind a labs flag for the time being.

Logs being sent: no

Version information

  • Platform: desktop

For the desktop app:

  • OS: Arch
  • Version: aur/element-desktop-nightly-bin 2021051101-1
@SimonBrandner
Copy link
Contributor

SimonBrandner commented May 11, 2021 •
edited
Loading

It'll probably be sane to hide it behind labs and maybe re-create my PR and add it to labs as well

@t3chguy
Copy link
Member

t3chguy commented May 11, 2021

The Matrix spec supports it though, and it can still be viewed for those who want to see it in View Source, but not showing it for all to see all the time in the timeline is a good thing.

@HarHarLinks
Copy link
Contributor Author

By that argument, you should also hide the input field in either devtools or labs

@SimonBrandner SimonBrandner mentioned this issue Aug 17, 2021
Open
@SimonBrandner SimonBrandner added Easy O-Occasional Affects or can be seen by some users regularly or most users rarely and removed T-Defect labels Aug 27, 2021
@kittykat kittykat added good first issue Good for newcomers and removed Easy labels Sep 2, 2021
@dbkr
Copy link
Member

dbkr commented Jan 17, 2022

Changing from good first issue to needs product so we can get confirmation on whether this is what we want to do.

@dbkr dbkr added X-Needs-Product More input needed from the Product team and removed good first issue Good for newcomers labels Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Redaction O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kittykat @dbkr @t3chguy @HarHarLinks @SimonBrandner