-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resetting security passphrase is too complex / error prone #16118
Comments
Same error after resetting, after trying to enter new code i got error "Wrong Recovery Key " |
I have the same problem as well, which means there's no way for me to verify another session. |
@DAlperin @SierraN @Azorlogh Sorry for the trouble here, can you try the following steps?
If that fails at some step, please submit debug logs and link to this issue so we investigate further. |
Huh, that seems to work. What's happening differently behind the hood that makes that work instead of the regular reset? |
It worked for me as well 👍 |
We were also affected by this issue. The workaround by @jryans worked, but it's not ideal for our users. |
I'm glad to hear the steps above are working. 🙂
Cross-signing and secret storage have somewhat complex, cyclical dependencies between each other. At the moment, we offer two separate targeted reset buttons:
However, we don't really explain any of that in the UI today, so I assume most people don't know why they'd want one vs. the other. Because of the cyclical dependencies between the two systems mentioned above, resetting one but not the other can lead to confusing prompts asking for a security phrase, but it might want the old one or the new one, which is quite confusing. All of this suggests it might be simpler to only offer a single reset button that always performs all of the steps outlined above. This would no longer allow for a targeted reset of e.g. just cross-signing separate from the rest, but it would simpler for most people to reason about, I assume. For now, let's keep this issue open so it's easy to find for any others with a similar problem, and we can evaluate potential improvements to the reset flow that might resolve confusion in the future. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
As mentioned in #16879 (comment), there are quite a few issues where people have generally been confused by the process. |
@jryans A single master reset button is certainly the way forward, but you could also have a confirmation page for the master reset button with an |
I'm going to close this issue for now as the workflow has been redesigned and was release a couple of months ago. Please open a new issue for further improvement. Thank you! |
Description
If I reset my security passphrase, the passphrase I just set will be immediately rejected when I attempt to use it to verify another session
Steps to reproduce
reset
Enter a security phrase
-> enter code -> reenter -> download backup codesManually Verify by Text
->Verify Session
Invalid Recovery Key
Wrong Recovery Key
Expected: The code I just set and the backup codes I just downloaded work
Actual: they do not work
Version information
For the web app:
For the desktop app:
The text was updated successfully, but these errors were encountered: