-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending a tombstone event in favor of an existing room lead to two annoying side effects #14532
Comments
2nd side effect is #10380 |
Isn't it? https://matrix.org/docs/spec/client_server/r0.6.1#id160
|
Yea, unfortunately we're not able to tell the difference between a redirect and an upgrade. Abusing tombstones for this purpose is generally not recommended, and the people who did recommend this approach will have known that it'll be counted as an upgrade. |
True, sorry, I've seen that on RiotX |
The m.room.create does not contains a predecessor in case of a redirect. |
From a spec perspective, this is an invalid event not a redirect. Redirects are not a thing. |
I observe this by sending a tombstone event to RiotX android room and link the tombstone event to Element-Android room.
It's maybe some sort of a hack usage of tombstone event though.
Steps:
First small bug:
RoomA claims that the room has been upgraded. This is not the case.
First side effect:
Clicking on the link of tombstone event rendering in RoomA send the user to the beginning of RoomB (the create event). In this case, as this is not a room upgrade, user should should land to the latest message of RoomB
Second side effect:
Leaving RoomA makes the app also leaves RoomB which is quite annoying.
RoomB's create event does not refer to RoomA as a predecessor, so in this case RoomB should not be left automatically.
The text was updated successfully, but these errors were encountered: