Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible crypto: Verified Identity change notice on composer: part 1. #2715

Open
2 of 4 tasks
BillCarsonFr opened this issue Feb 3, 2025 · 0 comments
Open
2 of 4 tasks
Assignees

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Feb 3, 2025

This is a subset of #2492

Adds minimum support for verified identity change warning notice.

Scope

Fix current implementation inconsistency and provide better UX for verified user who are not anymore.

Figma reference

EX: Show violation warning and disable sending
Web: Show the violation warning
Add a FAQ entry for verification violation

Know Limitations

  • The banner only shows the Withdraw Verification and not the Go to Profile option (because currently EX doesn't support verifying other users
  • EX: Some possible edge cases on the composer if the violation happens in the middle of for example recording an audio (the composer currently has no support for such interruptions)
  • There is no distinction between a verification violation caused by the other changing their identity or the current user changing it's identity (see Invisible crypto: Handle Identity Verification violation after we reset our own identity #2691). Same message is sent in both cases
  • Web design needs polishing to match the figma (unwanted padding, gradient in dark mode?)

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant