Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Room detail page #1103

Closed
3 tasks done
VolkerJunginger opened this issue Mar 8, 2023 · 11 comments
Closed
3 tasks done

[Story] Room detail page #1103

VolkerJunginger opened this issue Mar 8, 2023 · 11 comments

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Mar 8, 2023

As a user I want to be able to access a room-detail-page from the room header so that I can get some info about the room.

Show the following details:

Feature Room- Details
Show Avatar yes
Show Name yes
Matrix-ID yes
Room Description / Topic yes
→ Encryption: Info + Verify user Info only
→ Room-Members list yes
Leave Room  yes

Scope

These should be a list of technical tasks which take ½-1 day to complete

Android

Preview Give feedback
  1. csmith
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion

iOS

Preview Give feedback
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion

Stretch goals

None at this time

Out of scope

@amshakal
Copy link

amshakal commented Mar 27, 2023

Design will first work on features being implemented right now and then focus on the rest of the features as additional info might be needed for each and every one of them. eg. scope of audio/video call has not been defined yet, we don't know what encryption and verify user flow will look like based on what crypto team plans on doing etc.

Additionally slightly worried to have search here. Timeline might be a better place to search for messages.

@amshakal
Copy link

Are we sure we can and want to do links as well?

@amshakal
Copy link

amshakal commented Apr 5, 2023

@manuroe
Copy link
Member

manuroe commented Apr 11, 2023

@kittykat: iOS is ready for QA

@manuroe manuroe closed this as completed Apr 11, 2023
@manuroe manuroe reopened this Apr 11, 2023
@jmartinesp
Copy link
Member

@kittykat Android is ready for QA too. You can test this in the latest nightly.

@kittykat kittykat assigned ghost Apr 13, 2023
@ghost
Copy link

ghost commented May 19, 2023

Testing this on iOS 16.3.1 with an iPhone 12 mini on Element X 1.1.0 (218), this seems to be mostly okay.

I encountered an issue with very large rooms like Matrix HQ though so I filed it here.

@kittykat kittykat added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label May 26, 2023
@kittykat
Copy link
Contributor

kittykat commented Jun 15, 2023

@jmartinesp is it correct that links in the topic are not clickable and cannot be copied? Apart from that, passed on Android

@jmartinesp
Copy link
Member

@jmartinesp is it correct that links in the topic are not clickable and cannot be copied? Apart from that, passed on Android

I didn't see it in the requirements, but it would definitely be helpful. Maybe we could create a new issue for that?

@kittykat
Copy link
Contributor

Filed element-hq/element-x-android#612 and element-hq/element-x-android#613 for Android about room topics.

@ghost ghost removed their assignment Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

I think we can consider this conditionally signed off by QA. Once the two issues reported by Kat are resolved I'd consider this good to go for public testing.

@kittykat kittykat closed this as completed Jul 5, 2023
@kittykat
Copy link
Contributor

kittykat commented Jul 5, 2023

We can fix links as follow on work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants