Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted messages visible with "View Source" #5730

Closed
git-bruh opened this issue Apr 11, 2022 · 1 comment
Closed

Deleted messages visible with "View Source" #5730

git-bruh opened this issue Apr 11, 2022 · 1 comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@git-bruh
Copy link

git-bruh commented Apr 11, 2022 •
edited
Loading

Steps to reproduce

  1. Open any room (encrypted/non-encrypted)
  2. Send (or receive) a message
  3. Delete the message
  4. Long press the deleted message and tap on "View Source"

Outcome

What did you expect?

The content key of the json should have an empty value.

What happened instead?

Original message content is visible. This happens because view source is supposed to show the original content without edits, as a consequence it shows the deleted content aswell. But I expected the deleted content to be cleaned from the database by replacing the content key of the relevant event with an empty json {}.

Screenshot_20220411-151046_Fork_Launcher_1
Screenshot_20220411-151050_Fork_Launcher_1

Your phone model

No response

Operating system version

No response

Application version and app store

1.4.11 from github releases

Homeserver

No response

Will you send logs?

No
@git-bruh git-bruh added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 11, 2022
@ericdecanini ericdecanini added S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 11, 2022
@bmarty
Copy link
Member

bmarty commented Apr 22, 2022

This is fixed in 1.4.12 (by #5707)

@bmarty bmarty closed this as completed Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmarty @ericdecanini @git-bruh