Electron Packager 18.1.2 breaks electron-forge

[benbucksch]

Preflight Checklist

• I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

• Electron Packager Version:
  • 18.1.2
• Electron Version:
  • 28.0.0
• Operating System:
  • Ubuntu 20.04 x64
• Last Known Working Electron Packager version::
  • 18.1.1

Expected Behavior

• Electron starts

Actual Behavior

$ electron-forge start

An unhandled exception has occurred inside Forge:
Cannot find module '@electron/packager/src/targets'
Require stack:
- .../node_modules/@electron-forge/core/dist/util/parse-archs.js
- .../node_modules/@electron-forge/core/dist/api/make.js
- .../node_modules/@electron-forge/core/dist/api/index.js
- .../node_modules/@electron-forge/cli/dist/util/check-system.js
- .../node_modules/@electron-forge/cli/dist/electron-forge.js
Error: Cannot find module '@electron/packager/src/targets'
Require stack:
- .../node_modules/@electron-forge/core/dist/util/parse-archs.js
- .../node_modules/@electron-forge/core/dist/api/make.js
- .../node_modules/@electron-forge/core/dist/api/index.js
- .../node_modules/@electron-forge/cli/dist/util/check-system.js
- .../node_modules/@electron-forge/cli/dist/electron-forge.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
    at Module._load (node:internal/modules/cjs/loader:920:27)
    at Module.require (node:internal/modules/cjs/loader:1141:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (.../node_modules/@electron-forge/core/dist/util/parse-archs.js:5:51)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Module._load (node:internal/modules/cjs/loader:958:12)
    at Module.require (node:internal/modules/cjs/loader:1141:19)
error Command failed with exit code 1.

To Reproduce

1. Create a simple electron app using electron-forge
2. yarn install
3. yarn start

Additional Information

When I downgrade using yarn add @electron/[email protected] and do yarn start, Electron starts. When I upgrade again using yarn add @electron/[email protected] and do yarn start, the above problem appears.

• With 18.1.1, ls node_modules/\@electron/packager/src/targers.js shows that the file exists.
• With 18.1.2, ls node_modules/\@electron/packager/ shows that the src/ directory no longer exists and was replaced by dist/.

The release notes of Electron Packager only mention documentation changes: "update broken documentation links" is the only release note to the 1.8.2 release. It appears the entire TypeScript rewrite #1593 was shipped crediting as "update broken doc link".

[welcome]

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[benbucksch]

Fixed by electron/forge #3419