diff --git a/packages/electron-webpack/src/targets/BaseTarget.ts b/packages/electron-webpack/src/targets/BaseTarget.ts index 9c8a9e6..218cfce 100644 --- a/packages/electron-webpack/src/targets/BaseTarget.ts +++ b/packages/electron-webpack/src/targets/BaseTarget.ts @@ -108,7 +108,8 @@ function configureDevelopmentPlugins(configurator: WebpackConfigurator) { const plugins = configurator.plugins configurator.config.optimization!!.namedModules = true plugins.push(new DefinePlugin({ - __static: `"${path.join(configurator.projectDir, "static").replace(/\\/g, "\\\\")}"` + __static: `"${path.join(configurator.projectDir, "static").replace(/\\/g, "\\\\")}"`, + "process.env.NODE_ENV": configurator.isProduction ? "\"production\"" : "\"development\"" })) plugins.push(new HotModuleReplacementPlugin()) diff --git a/packages/electron-webpack/src/targets/RendererTarget.ts b/packages/electron-webpack/src/targets/RendererTarget.ts index 13fb0a3..0599920 100644 --- a/packages/electron-webpack/src/targets/RendererTarget.ts +++ b/packages/electron-webpack/src/targets/RendererTarget.ts @@ -86,13 +86,6 @@ export class BaseRendererTarget extends BaseTarget { configurator.debug("Add ExtractTextPlugin plugin") configurator.plugins.push(new MiniCssExtractPlugin({filename: `${configurator.type === "renderer-dll" ? "vendor" : "styles"}.css`})) - // https://github.com/electron-userland/electrify/issues/1 - if (!configurator.isProduction) { - configurator.plugins.push(new DefinePlugin({ - "process.env.NODE_ENV": "\"development\"", - })) - } - await BaseTarget.prototype.configurePlugins.call(this, configurator) } }