Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for snapcraft compression top-level key #5881

Open
pachulo opened this issue May 12, 2021 · 10 comments · Fixed by #6201
Open

Add support for snapcraft compression top-level key #5881

pachulo opened this issue May 12, 2021 · 10 comments · Fixed by #6201

Comments

@pachulo
Copy link

pachulo commented May 12, 2021

Snap packages are known for having a very long first startup time. That's mainly because snaps are compressed squashfs images using XZ algorithm. Recently Canonical made it possible to use LZO algorithm instead of XZ, which significantly improves startup time.

I'd like to ask for electron-builder to support the snapcraft top-level key compression. From https://snapcraft.io/docs/snapcraft-top-level-metadata:

Sets the compression type for the snap. Can be xz or lzo. Defaults to xz when not specified.
Snaps are compressed using xz data compression by default. This offers the optimal performance to compression ratio for the majority of snaps.
However, there are certain types of snap, such as large desktop applications, that can benefit from using LZO compression. Snaps compressed with lzo are slightly larger but can decompress quicker, reducing the time it takes for freshly installed or refreshed snaps to launch.

More info:

This is related to bitwarden/clients#2609

@mmaietta
Copy link
Collaborator

That sounds like a nice idea. Happy to accept a PR for this addition!
It should be fairly simple to get a local dev environment set up in conjunction with your project 🙂
https://github.com/electron-userland/electron-builder/blob/master/CONTRIBUTING.md#to-setup-a-local-dev-environment

@stale
Copy link

stale bot commented Jul 21, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Jul 21, 2021
@pachulo
Copy link
Author

pachulo commented Jul 21, 2021

Is this still relevant?

Yes, it is.

If so, what is blocking it?

My lack of time to work on it.

Is there anything you can do to help move it forward?

Well, I guess it's not that hard to implement, but I didn't really look at it.

@stale stale bot removed the backlog label Jul 21, 2021
@om26er
Copy link
Contributor

om26er commented Aug 25, 2021

@pachulo @mmaietta I will take a dig at that during the weekend, will try to propose a fix then

@om26er
Copy link
Contributor

om26er commented Aug 29, 2021

Here is the PR to fix this issue #6201

@ppd
Copy link
Contributor

ppd commented Dec 16, 2021

I think the PR is almost complete. @mmaietta maybe you can have a quick look over the proposed changes sometime soon. It would be great to land this in the near future.

@om26er
Copy link
Contributor

om26er commented Jan 13, 2022

This is done via #6201

@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 16, 2022
@pachulo
Copy link
Author

pachulo commented Apr 19, 2022

I guess it's only a matter of this being released on a stable release.

@julian-alarcon
Copy link

This is related to #7013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants