Skip to content

Commit eb842f7

Browse files
authored
fix(packager): return success status from doSign function calls (#7431)
1 parent 22ee62a commit eb842f7

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.changeset/real-poets-compare.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
fix packager: return success status from doSign function calls

packages/app-builder-lib/src/macPackager.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
376376
}
377377

378378
//noinspection JSMethodCanBeStatic
379-
protected async doSign(opts: SignOptions): Promise<any> {
379+
protected doSign(opts: SignOptions): Promise<any> {
380380
return signAsync(opts)
381381
}
382382

@@ -457,7 +457,6 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
457457

458458
const appFileName = `${this.appInfo.productFilename}.app`
459459
await readDirectoryAndSign(packContext.appOutDir, await readdir(packContext.appOutDir), file => file === appFileName)
460-
461460
if (!isAsar) {
462461
return true
463462
}

packages/app-builder-lib/src/winPackager.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {
210210
const cscInfo = await this.cscInfo.value
211211
if (cscInfo == null) {
212212
if (this.platformSpecificBuildOptions.sign != null) {
213-
await sign(signOptions, this)
213+
return await sign(signOptions, this)
214214
} else if (this.forceCodeSigning) {
215215
throw new InvalidConfigurationError(
216216
`App is not signed and "forceCodeSigning" is set to true, please ensure that code signing configuration is correct, please see https://electron.build/code-signing`

0 commit comments

Comments
 (0)