Skip to content

Commit df7a425

Browse files
authored
fix(app-builder-lib): channel alternation for github is not working (#6449)
1 parent 828fcd3 commit df7a425

File tree

3 files changed

+23
-4
lines changed

3 files changed

+23
-4
lines changed
+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
Enable channel alternation for github publishing provider.

packages/app-builder-lib/scheme.json

+9-1
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@
525525
"additionalProperties": false,
526526
"properties": {
527527
"checksum": {
528-
"default": "o+YZsXHp8LNihhuk7JsCDhdIgx0MKKK+1b3sGD+4zX5djZULe4/4QMcAsfQ+0r+a8FnwBt7BVBHkIkJHjKQ0sg==",
528+
"default": "VKMiizYdmNdJOWpRGz4trl4lD++BvYP2irAXpMilheUP0pc93iKlWAoP843Vlraj8YG19CVn0j+dCo/hURz9+Q==",
529529
"type": [
530530
"null",
531531
"string"
@@ -1505,6 +1505,14 @@
15051505
"additionalProperties": false,
15061506
"description": "[GitHub](https://help.github.com/articles/about-releases/) options.\n\nGitHub [personal access token](https://help.github.com/articles/creating-an-access-token-for-command-line-use/) is required. You can generate by going to [https://github.com/settings/tokens/new](https://github.com/settings/tokens/new). The access token should have the repo scope/permission.\nDefine `GH_TOKEN` environment variable.",
15071507
"properties": {
1508+
"channel": {
1509+
"default": "latest",
1510+
"description": "The channel.",
1511+
"type": [
1512+
"null",
1513+
"string"
1514+
]
1515+
},
15081516
"host": {
15091517
"default": "github.com",
15101518
"description": "The host (including the port if need).",

packages/builder-util-runtime/src/publishOptions.ts

+9-3
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ export interface GithubOptions extends PublishConfiguration {
115115
*/
116116
readonly private?: boolean | null
117117

118+
/**
119+
* The channel.
120+
* @default latest
121+
*/
122+
readonly channel?: string | null
123+
118124
/**
119125
* The type of release. By default `draft` release will be created.
120126
*
@@ -193,7 +199,7 @@ export interface KeygenOptions extends PublishConfiguration {
193199
* Bitbucket options.
194200
* https://bitbucket.org/
195201
* Define `BITBUCKET_TOKEN` environment variable.
196-
*
202+
*
197203
* For converting an app password to a usable token, you can utilize this
198204
```typescript
199205
convertAppPassword(owner: string, token: string) {
@@ -282,9 +288,9 @@ export interface BaseS3Options extends PublishConfiguration {
282288
* AWS credentials are required, please see [getting your credentials](http://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/getting-your-credentials.html).
283289
* Define `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` [environment variables](http://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-environment.html).
284290
* Or in the [~/.aws/credentials](http://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-shared.html).
285-
*
291+
*
286292
* Example configuration:
287-
*
293+
*
288294
```json
289295
{
290296
"build":

0 commit comments

Comments
 (0)