fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE when specifying appPackageUrl (#6964)

geovie · web-flow · commit b0e1b6f8af95 · 2022-07-03T20:22:34.000-07:00
diff --git a/.changeset/cuddly-books-approve.md b/.changeset/cuddly-books-approve.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE
diff --git a/packages/app-builder-lib/src/targets/nsis/WebInstallerTarget.ts b/packages/app-builder-lib/src/targets/nsis/WebInstallerTarget.ts
@@ -29,10 +29,9 @@ export class WebInstallerTarget extends NsisTarget {
       }
 
       appPackageUrl = computeDownloadUrl(publishConfigs[0], null, packager)
-
-      defines.APP_PACKAGE_URL_IS_INCOMLETE = null
     }
 
+    defines.APP_PACKAGE_URL_IS_INCOMPLETE = null
     defines.APP_PACKAGE_URL = appPackageUrl
   }
 
diff --git a/packages/app-builder-lib/templates/nsis/include/webPackage.nsh b/packages/app-builder-lib/templates/nsis/include/webPackage.nsh
@@ -5,7 +5,7 @@
   StrCpy $packageUrl "${APP_PACKAGE_URL}"
   StrCpy $packageArch "${APP_PACKAGE_URL}"
 
-  !ifdef APP_PACKAGE_URL_IS_INCOMLETE
+  !ifdef APP_PACKAGE_URL_IS_INCOMPLETE
     !ifdef APP_64_NAME
       !ifdef APP_32_NAME
 	    	!ifdef APP_ARM64_NAME

Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,9 @@ export class WebInstallerTarget extends NsisTarget {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`appPackageUrl = computeDownloadUrl(publishConfigs[0], null, packager)`
`32`		`-`
`33`		`- defines.APP_PACKAGE_URL_IS_INCOMLETE = null`
`34`	`32`	`}`
`35`	`33`
	`34`	`+ defines.APP_PACKAGE_URL_IS_INCOMPLETE = null`
`36`	`35`	`defines.APP_PACKAGE_URL = appPackageUrl`
`37`	`36`	`}`
`38`	`37`