Skip to content

Commit 8730027

Browse files
authored
fix: add warning to macCodeSign when skipping code signing on M1 macOS device (#6522)
On M1 macOS laptop, If you skip code signing, it will cause your bundled macOS app not to work as expected. e.g. - The macOS localization description will not visible in the request permission action. - The macOS request permission grant notify will trigger multiple times
1 parent 344bb23 commit 8730027

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/app-builder-lib/src/codeSign/macCodeSign.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export async function reportError(
6767
if (qualifier == null) {
6868
logFields.reason = ""
6969
if (isAutoDiscoveryCodeSignIdentity()) {
70-
logFields.reason += `cannot find valid "${certificateTypes.join(", ")}" identity${isMas ? "" : ` or custom non-Apple code signing certificate`}`
70+
logFields.reason += `cannot find valid "${certificateTypes.join(", ")}" identity${isMas ? "" : ` or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible`}`
7171
}
7272
logFields.reason += ", see https://electron.build/code-signing"
7373
if (!isAutoDiscoveryCodeSignIdentity()) {

0 commit comments

Comments
 (0)