From 869c7e4652a5d5a3562e25723d6cedd622ab657b Mon Sep 17 00:00:00 2001 From: Bret Comnes <166301+bcomnes@users.noreply.github.com> Date: Wed, 20 Dec 2023 11:58:35 -0800 Subject: [PATCH] fix: notarization with an apple API key (#7951) Notarization wasn't actually running when the API key is set and notarize was set to true. The notarize tool library throws when a API key is provided and teamId is set, so you have to set notarize to true, but when you do currently, the step never runs. --- .changeset/shaggy-plums-live.md | 5 +++++ packages/app-builder-lib/src/macPackager.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/shaggy-plums-live.md diff --git a/.changeset/shaggy-plums-live.md b/.changeset/shaggy-plums-live.md new file mode 100644 index 00000000000..254f6ba17af --- /dev/null +++ b/.changeset/shaggy-plums-live.md @@ -0,0 +1,5 @@ +--- +"app-builder-lib": patch +--- + +fix: notarization with an apple API key diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts index 4e03d2bbc50..8124d9b686f 100644 --- a/packages/app-builder-lib/src/macPackager.ts +++ b/packages/app-builder-lib/src/macPackager.ts @@ -544,7 +544,7 @@ export default class MacPackager extends PlatformPackager { return proj } const { teamId } = options as NotarizeNotaryOptions - if (teamId && (legacyLogin || notaryToolLogin)) { + if ((teamId || options === true) && (legacyLogin || notaryToolLogin)) { const proj: NotaryToolStartOptions = { appPath, ...(legacyLogin ?? notaryToolLogin!),