fix(nsis): cleanup temporary 7z folder (#6793)

Before attempting to extract files with non-discriminating `Nsis7z::Extract` that ignores the errors remove the temporary folder so that we don't require twice as much disk space for this last resort measure.

Additionally, replace `Quit` with a `Goto DoneExtract7za` so that the last resort measure actually works.

Author: indutny-signal

.changeset/fifty-schools-arrive.md

@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix(nsis): cleanup temporary 7z folder before the last resort extraction. Fix last resort extraction exiting early.

packages/app-builder-lib/templates/nsis/include/extractAppPackage.nsh

@@ -113,13 +113,21 @@
       # Try copying a few times before asking for a user action.
       Goto RetryExtract7za
     ${else}
-      MessageBox MB_RETRYCANCEL|MB_ICONEXCLAMATION "$(appCannotBeClosed)" /SD IDCANCEL IDRETRY RetryExtract7za
+      MessageBox MB_RETRYCANCEL|MB_ICONEXCLAMATION "$(appCannotBeClosed)" /SD IDRETRY IDCANCEL AbortExtract7za
     ${endIf}
 
     # As an absolutely last resort after a few automatic attempts and user
     # intervention - we will just overwrite everything with `Nsis7z::Extract`
     # even though it is not atomic and will ignore errors.
+
+    # Clear the temporary folder first to make sure we don't use twice as
+    # much disk space.
+    RMDir /r "$PLUGINSDIR\7z-out"
+
     Nsis7z::Extract "${FILE}"
+    Goto DoneExtract7za
+
+  AbortExtract7za:
     Quit
 
   RetryExtract7za: