Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce UTF-8 encoding for file I/O #402

Closed
danielmitterdorfer opened this issue Jan 24, 2018 · 0 comments
Closed

Enforce UTF-8 encoding for file I/O #402

danielmitterdorfer opened this issue Jan 24, 2018 · 0 comments
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Milestone

Comments

@danielmitterdorfer
Copy link
Member

Currently we rely on the platform encoding when doing file I/O. Usually the platform encoding is set to UTF-8 so it does not make a difference in many cases. However, we should strictly enforce UTF-8 encoding on all file I/O to avoid failures due to the platform encoding.

We should specifically watch out for these places:

  • Writing / reading Rally's config file
  • Reading bulk data files
  • Writing / reading Elasticsearch config files
  • Reading index config files for the metrics store
  • Writing / reading race.json files
  • Writing race report files

To test it, we can set the platform encoding with export LC_ALL = C.

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jan 24, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.9.2 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

No branches or pull requests

1 participant