Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check-all Makefile target #1297

Closed
pquentin opened this issue Jun 30, 2021 · 1 comment · Fixed by #1299
Closed

Add a check-all Makefile target #1297

pquentin opened this issue Jun 30, 2021 · 1 comment · Fixed by #1299

Comments

@pquentin
Copy link
Member

As mentioned by @dliappis in #1281 (review), it would be useful to do make check-all. It's easy to implement:

check-all: lint test it

But I don't know where to mention it. For example, we don't mention it tests anywhere. (And we probably should, I took some time to understand that those were integration tests.)

Maybe this can be left undocumented, as it is something that only the core team will actually run?

@dliappis
Copy link
Contributor

dliappis commented Jun 30, 2021

But I don't know where to mention it. For example, we don't mention it tests anywhere. (And we probably should, I took some time to understand that those were integration tests.)
Maybe this can be left undocumented, as it is something that only the core team will actually run?

We could mention it in the contributor's guide. Right now step 1 is python3 setup.py test but instead it could be to first format the changes and then ensure all tests pass with make check-all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants