-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support composable templates #1054
Comments
Thanks for raising this. I tend to the first option of dedicated runner(s) as I don't think Rally should abstract the Elasticsearch APIs much. |
Also 👍 on dedicated runners; these should be first class citizens in Rally. |
@danielmitterdorfer @dliappis the current template implementation uses the deprecated API. I'm not sure if the intention is to remove this in 8.0. For now, i propose we make these additions. Do we want these to be first class definitions in the track? i.e. Alternatively, we could require a single definition e.g.
The benefit of declaring these as first class citizens is that we can use the definitions in other runners should we need them e.g. for validation. |
Closed by #1099 |
7.8 introduced composable and component templates. The unique api endpoints mean this is work.
We may want to separate these into different operations given the unique endpoints. A user would therefore index a set of component templates, followed by their composable templates.
Alternatively, we could extend the current create-template action to accept a
mode
where it first inserts the declaredcomponent_templates
and thencomposable_templates
that have been declared in the track. This would be a non breaking change as the mode would default tolegacy
which would cause the current behaviour.@dliappis @danielmitterdorfer happy to take but please advise
The text was updated successfully, but these errors were encountered: