-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the saved-object usage collector's alias from text to keyword #91064
Conversation
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Firefox XPack UI Functional Tests.x-pack/test/functional/apps/grok_debugger/grok_debugger·js.logstash grok debugger app "before all" hook in "grok debugger app"Standard Out
Stack Trace
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kobelb LGTM! We should be able to update the telemetry mappings from text
to keyword
without much trouble. It is a scenario we are very familiar with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport result
|
#91064) (#91170) Co-authored-by: Brandon Kobel <[email protected]>
Previously, the saved-object alias was being mapped as
text
. This causes it to be analyzed, which we don't want.@Bamieh is it alright to change the data-type of an existing field?