From af16b22585262856d2ca745d700ba6eb07c69997 Mon Sep 17 00:00:00 2001 From: Tim Roes Date: Fri, 30 Oct 2020 15:28:31 +0100 Subject: [PATCH 1/3] Cleanup codeowners --- .github/CODEOWNERS | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 36e9f4220b35c..c179dbadac533 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -39,10 +39,6 @@ #CC# /src/legacy/core_plugins/vis_type_vislib/ @elastic/kibana-app #CC# /src/legacy/server/url_shortening/ @elastic/kibana-app #CC# /src/legacy/ui/public/state_management @elastic/kibana-app -#CC# /src/plugins/advanced_settings/ @elastic/kibana-app -#CC# /src/plugins/charts/ @elastic/kibana-app -#CC# /src/plugins/index_pattern_management/public @elastic/kibana-app -#CC# /src/plugins/vis_default_editor @elastic/kibana-app # App Architecture /examples/bfetch_explorer/ @elastic/kibana-app-arch @@ -74,7 +70,7 @@ /x-pack/plugins/embeddable_enhanced/ @elastic/kibana-app-arch /x-pack/plugins/ui_actions_enhanced/ @elastic/kibana-app-arch #CC# /src/plugins/bfetch/ @elastic/kibana-app-arch -#CC# /src/plugins/index_pattern_management/public/service @elastic/kibana-app-arch +#CC# /src/plugins/index_pattern_management/ @elastic/kibana-app-arch #CC# /src/plugins/inspector/ @elastic/kibana-app-arch #CC# /src/plugins/share/ @elastic/kibana-app-arch #CC# /x-pack/plugins/advanced_ui_actions/ @elastic/kibana-app-arch From b6ebcb3f04617337fe04cbbbe36b239095a869ef Mon Sep 17 00:00:00 2001 From: Tim Roes Date: Fri, 30 Oct 2020 16:04:52 +0100 Subject: [PATCH 2/3] Add missing readmes --- docs/developer/plugin-list.asciidoc | 12 ++++++++---- src/plugins/advanced_settings/README.md | 5 +++++ src/plugins/management/README.md | 5 +++++ 3 files changed, 18 insertions(+), 4 deletions(-) create mode 100644 src/plugins/advanced_settings/README.md create mode 100644 src/plugins/management/README.md diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc index 4387e168f412d..d0808d73151b0 100644 --- a/docs/developer/plugin-list.asciidoc +++ b/docs/developer/plugin-list.asciidoc @@ -22,8 +22,10 @@ NOTE: |Description -|{kib-repo}blob/{branch}/src/plugins/advanced_settings[advancedSettings] -|WARNING: Missing README. +|{kib-repo}blob/{branch}/src/plugins/advanced_settings/README.md[advancedSettings] +|This plugin contains the advanced settings management section +allowing users to configure their advanced settings, also known +as uiSettings within the code. |{kib-repo}blob/{branch}/src/plugins/apm_oss[apmOss] @@ -130,8 +132,10 @@ in Kibana, e.g. visualizations. It has the form of a flyout panel. |WARNING: Missing README. -|{kib-repo}blob/{branch}/src/plugins/management[management] -|WARNING: Missing README. +|{kib-repo}blob/{branch}/src/plugins/management/README.md[management] +|This plugins contains the "Stack Management" page framework. It offers navigation and an API +to link individual managment section into it. This plugin does not contain any individual +management section itself. |{kib-repo}blob/{branch}/src/plugins/maps_legacy/README.md[mapsLegacy] diff --git a/src/plugins/advanced_settings/README.md b/src/plugins/advanced_settings/README.md new file mode 100644 index 0000000000000..a364348a8e99a --- /dev/null +++ b/src/plugins/advanced_settings/README.md @@ -0,0 +1,5 @@ +# Advanced Settings + +This plugin contains the advanced settings management section +allowing users to configure their advanced settings, also known +as uiSettings within the code. \ No newline at end of file diff --git a/src/plugins/management/README.md b/src/plugins/management/README.md new file mode 100644 index 0000000000000..0498aed76c020 --- /dev/null +++ b/src/plugins/management/README.md @@ -0,0 +1,5 @@ +# Managament Plugin + +This plugins contains the "Stack Management" page framework. It offers navigation and an API +to link individual managment section into it. This plugin does not contain any individual +management section itself. \ No newline at end of file From 2e1a81144dd749cf29eae859d229364944a67fbd Mon Sep 17 00:00:00 2001 From: Tim Roes Date: Fri, 30 Oct 2020 16:50:10 +0100 Subject: [PATCH 3/3] Fix typos --- src/plugins/management/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/management/README.md b/src/plugins/management/README.md index 0498aed76c020..097ecd95ea8fa 100644 --- a/src/plugins/management/README.md +++ b/src/plugins/management/README.md @@ -1,4 +1,4 @@ -# Managament Plugin +# Management Plugin This plugins contains the "Stack Management" page framework. It offers navigation and an API to link individual managment section into it. This plugin does not contain any individual