[SIEM] [Detection Engine] Remove unnecessary ts-ignores #58689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley14
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
… array items can result in undefined even though typescript says its not
dhurley14
commented
Feb 27, 2020
| @@ -222,8 +222,9 @@ export const getIndex = (getSpaceId: () => string, config: LegacyServices['confi | |||
| return `${signalsIndex}-${spaceId}`; | |||
| }; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| export const convertToSnakeCase = <T extends Record<string, any>>(obj: T): Partial<T> | null => { | |||
| export const convertToSnakeCase = <T extends Record<string, unknown>>( | |||
There was a problem hiding this comment.
removed explicit any and replaced with unknown.
💚 Build SucceededTo update your PR or re-run it, just comment with: |
dhurley14
added a commit
to dhurley14/kibana
that referenced
this pull request
Feb 27, 2020
* fixes from comments on previous PR * replaces any with unknown, adds test to show how optional chaining of array items can result in undefined even though typescript says its not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove ts-ignore lines from feedback here #58274 (review) and here #58274 (review)
Also replaces the any with unknown in the convertToSnakeCase function in order and provides a test case to show how an undefined can sneak past typescript (see microsoft/TypeScript#11122)
Checklist
Delete any items that are not applicable to this PR.
For maintainers