From a501988be4e65b9400a6fc83defbe10591e9595a Mon Sep 17 00:00:00 2001 From: Ahmad Bamieh Date: Tue, 23 Jul 2019 10:46:13 +0300 Subject: [PATCH 1/2] check for translations in file --- src/legacy/server/i18n/get_translations_path.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/legacy/server/i18n/get_translations_path.js b/src/legacy/server/i18n/get_translations_path.js index 95de6c7560660..6ac3e75e1d4a8 100644 --- a/src/legacy/server/i18n/get_translations_path.js +++ b/src/legacy/server/i18n/get_translations_path.js @@ -34,10 +34,12 @@ export async function getTranslationPaths({ cwd, glob }) { try { const content = await readFileAsync(entryFullPath, 'utf8'); const { translations } = JSON.parse(content); - translations.forEach(translation => { - const translationFullPath = resolve(pluginBasePath, translation); - translationPaths.push(translationFullPath); - }); + if (translations && translations.length) { + translations.forEach(translation => { + const translationFullPath = resolve(pluginBasePath, translation); + translationPaths.push(translationFullPath); + }); + } } catch (err) { throw new Error(`Failed to parse .i18nrc.json file at ${entryFullPath}`); } From 55e4aa6518f141cf8bd6e6469ce682b2a2f6be0f Mon Sep 17 00:00:00 2001 From: Ahmad Bamieh Date: Tue, 23 Jul 2019 10:53:21 +0300 Subject: [PATCH 2/2] update template --- .../kbn-plugin-generator/sao_template/template/.i18nrc.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/kbn-plugin-generator/sao_template/template/.i18nrc.json b/packages/kbn-plugin-generator/sao_template/template/.i18nrc.json index edcca37a248f0..3fb2834877898 100644 --- a/packages/kbn-plugin-generator/sao_template/template/.i18nrc.json +++ b/packages/kbn-plugin-generator/sao_template/template/.i18nrc.json @@ -1,5 +1,8 @@ { "paths": { "<%= camelCase(name) %>": "./" - } + }, + "translations": [ + "translations/zh-CN.json" + ] }