[8.18] [Rules migration][Integration test] Update migration API (#11232) (#211196) #211296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) (elastic#211196) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations Update API (route: `PUT /internal/siem_migrations/rules/{migration_id}`) integration test: * Happy path * update migration * ignore attributes that are not eligible for update * Error handling * an empty content response * an error when rule's id is not specified * an error when undefined payload has been passed Also, as part of this PR, I added error handling cases for Create API: * no content error * an error when undefined payload has been passed * an error when original rule id is not specified * error when original rule vendor is not specified * an error when original rule title is not specified * an error when original rule description is not specified * an error when original rule query is not specified * an error when original rule query_language is not specified --------- Co-authored-by: Sergi Massaneda <[email protected]> (cherry picked from commit 819fd7a)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
cc @e40pud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:Questions ?
Please refer to the Backport tool documentation