[ES|QL] Separate GROK and DISSECT autocomplete routines
#211101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
Feature:ES|QL
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
|
|
Pinging @elastic/kibana-esql (Team:ESQL) |
darnautov
approved these changes
Feb 14, 2025
| @@ -20,7 +20,7 @@ export async function suggest({ | |||
| if (/INFO\s+$/i.test(innerText)) { | |||
| return [{ ...pipeCompleteItem, command: TRIGGER_SUGGESTION_COMMAND }]; | |||
| } | |||
| // SHOW INSOF / | |||
| // SHOW LOLZ / | |||
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13331506580 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
added a commit
that referenced
this pull request
Feb 15, 2025
…11101) (#211320) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Separate `GROK` and `DISSECT` autocomplete routines (#211101)](#211101) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-14T14:44:46Z","message":"[ES|QL] Separate `GROK` and `DISSECT` autocomplete routines (#211101)\n\n## Summary\n\nPart of https://github.com/elastic/kibana/issues/195418\n\nGives `GROK` and `DISSECT` autocomplete logic its own home 🏡\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n### Identify risks\n\n- [ ] As with any refactor, there's a possibility this will introduce a\nregression in the behavior of commands. However, all automated tests are\npassing and I have tested the behavior manually and can detect no\nregression.","sha":"1223926450736fba5f67d17279ccf650d8b3ff2a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Separate `GROK` and `DISSECT` autocomplete routines","number":211101,"url":"https://github.com/elastic/kibana/pull/211101","mergeCommit":{"message":"[ES|QL] Separate `GROK` and `DISSECT` autocomplete routines (#211101)\n\n## Summary\n\nPart of https://github.com/elastic/kibana/issues/195418\n\nGives `GROK` and `DISSECT` autocomplete logic its own home 🏡\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n### Identify risks\n\n- [ ] As with any refactor, there's a possibility this will introduce a\nregression in the behavior of commands. However, all automated tests are\npassing and I have tested the behavior manually and can detect no\nregression.","sha":"1223926450736fba5f67d17279ccf650d8b3ff2a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211101","number":211101,"mergeCommit":{"message":"[ES|QL] Separate `GROK` and `DISSECT` autocomplete routines (#211101)\n\n## Summary\n\nPart of https://github.com/elastic/kibana/issues/195418\n\nGives `GROK` and `DISSECT` autocomplete logic its own home 🏡\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n### Identify risks\n\n- [ ] As with any refactor, there's a possibility this will introduce a\nregression in the behavior of commands. However, all automated tests are\npassing and I have tested the behavior manually and can detect no\nregression.","sha":"1223926450736fba5f67d17279ccf650d8b3ff2a"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #195418
Gives
GROKandDISSECTautocomplete logic its own home 🏡Checklist
Identify risks