Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Presentation] Remove unused dependencies #206689

Merged
merged 3 commits into from
Jan 15, 2025
Merged

[Presentation] Remove unused dependencies #206689

merged 3 commits into from
Jan 15, 2025

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jan 14, 2025 •
edited by kibanamachine
Loading

Closes #205639

Summary

Now that #205341 is merged, we can remove both react-grid-layout and react-resizable since they are no longer used in Dashboard (and Dashboard was the only consumer, so they are no longer used anywhere in Kibana).

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

There are no risks to removing an unused dependency.

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. dependencies Pull requests that update a dependency file backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 14, 2025
@Heenawter Heenawter force-pushed the remove-rgl-dependecy_2025-01-14 branch from afe8d6a to 0b46f21 Compare January 14, 2025 22:17
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
c4e33e8 
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@Heenawter Heenawter marked this pull request as ready for review January 15, 2025 01:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter merged commit 364abf7 into elastic:main Jan 15, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12792095413

@Heenawter Heenawter deleted the remove-rgl-dependecy_2025-01-14 branch January 15, 2025 16:00
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- github-actions: notify github commands for all the observability code (#195219)

Manual backport

To create the backport manually run:

node scripts/backport --pr 206689

Questions ?

Please refer to the Backport tool documentation

@Heenawter Heenawter mentioned this pull request Jan 15, 2025
Merged
@Heenawter
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Heenawter added a commit to Heenawter/kibana that referenced this pull request Jan 15, 2025
@Heenawter
[Presentation] Remove unused dependencies (elastic#206689)
a001fe8 
Closes elastic#205639

## Summary

Now that elastic#205341 is merged, we can
remove both `react-grid-layout` and `react-resizable` since they are no
longer used in Dashboard (and Dashboard was the only consumer, so they
are no longer used anywhere in Kibana).

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

There are no risks to removing an unused dependency.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 364abf7)

# Conflicts:
#	renovate.json
@Heenawter Heenawter mentioned this pull request Jan 15, 2025
Closed
1 task
Heenawter added a commit that referenced this pull request Jan 15, 2025
@Heenawter
[8.x] [Presentation] Remove unused dependencies (#206689) (#206823)
6735744 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Presentation] Remove unused dependencies
(#206689)](#206689)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-15T15:54:54Z","message":"[Presentation]
Remove unused dependencies (#206689)\n\nCloses
https://github.com/elastic/kibana/issues/205639\r\n\r\n##
Summary\r\n\r\nNow that #205341 is
merged, we can\r\nremove both `react-grid-layout` and `react-resizable`
since they are no\r\nlonger used in Dashboard (and Dashboard was the
only consumer, so they\r\nare no longer used anywhere in
Kibana).\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Identify risks\r\n \r\nThere are no risks to removing an unused
dependency.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"364abf7b09f55f33e84d2f9b635715fc4de9fd92","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:small","release_note:skip","impact:medium","dependencies","v9.0.0","backport:prev-minor"],"title":"[Presentation]
Remove unused
dependencies","number":206689,"url":"https://github.com/elastic/kibana/pull/206689","mergeCommit":{"message":"[Presentation]
Remove unused dependencies (#206689)\n\nCloses
https://github.com/elastic/kibana/issues/205639\r\n\r\n##
Summary\r\n\r\nNow that #205341 is
merged, we can\r\nremove both `react-grid-layout` and `react-resizable`
since they are no\r\nlonger used in Dashboard (and Dashboard was the
only consumer, so they\r\nare no longer used anywhere in
Kibana).\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Identify risks\r\n \r\nThere are no risks to removing an unused
dependency.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"364abf7b09f55f33e84d2f9b635715fc4de9fd92"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206689","number":206689,"mergeCommit":{"message":"[Presentation]
Remove unused dependencies (#206689)\n\nCloses
https://github.com/elastic/kibana/issues/205639\r\n\r\n##
Summary\r\n\r\nNow that #205341 is
merged, we can\r\nremove both `react-grid-layout` and `react-resizable`
since they are no\r\nlonger used in Dashboard (and Dashboard was the
only consumer, so they\r\nare no longer used anywhere in
Kibana).\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Identify risks\r\n \r\nThere are no risks to removing an unused
dependency.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"364abf7b09f55f33e84d2f9b635715fc4de9fd92"}}]}]
BACKPORT-->
Heenawter added a commit to Heenawter/kibana that referenced this pull request Jan 15, 2025
@Heenawter
Revert "[Presentation] Remove unused dependencies (elastic#206689)"
cc41b34 
This reverts commit 364abf7.
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@Heenawter @kibanamachine @viduni94
[Presentation] Remove unused dependencies (elastic#206689)
8f76591 
Closes elastic#205639

## Summary

Now that elastic#205341 is merged, we can
remove both `react-grid-layout` and `react-resizable` since they are no
longer used in Dashboard (and Dashboard was the only consumer, so they
are no longer used anywhere in Kibana).

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks
 
There are no risks to removing an unused dependency.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) dependencies Pull requests that update a dependency file impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kbn-grid-layout] [Feature Parity] Remove react-grid-layout and other relevant dependencies
4 participants
@Heenawter @elasticmachine @kibanamachine @mbondyra