[Security Assistant] Add Knowledge Base entries API #206407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
💔 Build Failed
Failed CI StepsHistory
|
e40pud
reviewed
Jan 28, 2025
.../security/plugins/elastic_assistant/server/ai_assistant_data_clients/knowledge_base/index.ts
Show resolved
Hide resolved
| const documentsFilter = documentIds.map((id) => `_id:${id}`).join(' OR '); | ||
| const entries = await kbDataClient?.findDocuments<EsKnowledgeBaseEntrySchema>({ | ||
| page: 1, | ||
| perPage: 100, |
There was a problem hiding this comment.
Wondering if we should worry about this search at some point. If users will be adding lots of entries etc.
patrykkopycinski
changed the title
patrykkopycinski
added
release_note:enhancement
v9.0.0
backport:version
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13017926060 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
## Summary Expose Knowledge Base entries API --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit b128cee)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…208610) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Assistant] Add Knowledge Base entries API (#206407)](#206407) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-28T19:19:55Z","message":"[Security Assistant] Add Knowledge Base entries API (#206407)\n\n## Summary\r\n\r\nExpose Knowledge Base entries API\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b128cee4ee7ccc367e8acf159dbf58a75f081867","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Feature:Security Assistant","Team:Security Generative AI","backport:version","v8.18.0"],"title":"[Security Assistant] Add Knowledge Base entries API","number":206407,"url":"https://github.com/elastic/kibana/pull/206407","mergeCommit":{"message":"[Security Assistant] Add Knowledge Base entries API (#206407)\n\n## Summary\r\n\r\nExpose Knowledge Base entries API\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b128cee4ee7ccc367e8acf159dbf58a75f081867"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206407","number":206407,"mergeCommit":{"message":"[Security Assistant] Add Knowledge Base entries API (#206407)\n\n## Summary\r\n\r\nExpose Knowledge Base entries API\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b128cee4ee7ccc367e8acf159dbf58a75f081867"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Patryk Kopyciński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expose Knowledge Base entries API