From 3b917611d4062b566df5539d3d0df68d9d868203 Mon Sep 17 00:00:00 2001 From: Maryam Saeidi Date: Fri, 27 Sep 2024 17:50:48 +0200 Subject: [PATCH 1/4] Set useEcs to true in SLO burn rate rule --- .../slo/server/lib/rules/slo_burn_rate/register.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/slo/server/lib/rules/slo_burn_rate/register.ts b/x-pack/plugins/observability_solution/slo/server/lib/rules/slo_burn_rate/register.ts index 4e4c50305ef43..50e09e42512b7 100644 --- a/x-pack/plugins/observability_solution/slo/server/lib/rules/slo_burn_rate/register.ts +++ b/x-pack/plugins/observability_solution/slo/server/lib/rules/slo_burn_rate/register.ts @@ -115,7 +115,7 @@ export function sloBurnRateRuleType( alerts: { context: SLO_RULE_REGISTRATION_CONTEXT, mappings: { fieldMap: { ...legacyExperimentalFieldMap, ...sloRuleFieldMap } }, - useEcs: false, + useEcs: true, useLegacyAlerts: true, shouldWrite: true, }, From 719e1ea5f9fedaa52ac79009c68fc641eba170b5 Mon Sep 17 00:00:00 2001 From: Maryam Saeidi Date: Mon, 30 Sep 2024 09:52:57 +0200 Subject: [PATCH 2/4] Update observability_slo_schema --- .../src/schemas/generated/observability_slo_schema.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_slo_schema.ts b/packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_slo_schema.ts index d611dd0df138c..6dcd7d95dfda8 100644 --- a/packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_slo_schema.ts +++ b/packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_slo_schema.ts @@ -12,6 +12,7 @@ import * as rt from 'io-ts'; import { Either } from 'fp-ts/lib/Either'; import { AlertSchema } from './alert_schema'; +import { EcsSchema } from './ecs_schema'; import { LegacyAlertSchema } from './legacy_alert_schema'; const ISO_DATE_PATTERN = /^d{4}-d{2}-d{2}Td{2}:d{2}:d{2}.d{3}Z$/; export const IsoDateString = new rt.Type( @@ -88,6 +89,6 @@ const ObservabilitySloAlertOptional = rt.partial({ }); // prettier-ignore -export const ObservabilitySloAlertSchema = rt.intersection([ObservabilitySloAlertRequired, ObservabilitySloAlertOptional, AlertSchema, LegacyAlertSchema]); +export const ObservabilitySloAlertSchema = rt.intersection([ObservabilitySloAlertRequired, ObservabilitySloAlertOptional, AlertSchema, EcsSchema, LegacyAlertSchema]); // prettier-ignore export type ObservabilitySloAlert = rt.TypeOf; From 466a4a1c2af95509559b9ef615b689c460862a90 Mon Sep 17 00:00:00 2001 From: Maryam Saeidi Date: Mon, 30 Sep 2024 21:05:51 +0200 Subject: [PATCH 3/4] Fix test --- x-pack/test/api_integration/apis/maps/maps_telemetry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/test/api_integration/apis/maps/maps_telemetry.ts b/x-pack/test/api_integration/apis/maps/maps_telemetry.ts index acd846f77c982..4db33337429c1 100644 --- a/x-pack/test/api_integration/apis/maps/maps_telemetry.ts +++ b/x-pack/test/api_integration/apis/maps/maps_telemetry.ts @@ -36,7 +36,7 @@ export default function ({ getService }: FtrProviderContext) { return fieldStat.name === 'geo_point'; } ); - expect(geoPointFieldStats.count).to.be(47); + expect(geoPointFieldStats.count).to.be(55); expect(geoPointFieldStats.index_count).to.be(11); const geoShapeFieldStats = apiResponse.cluster_stats.indices.mappings.field_types.find( From 95a13af7e1a2b33cadcd9f31f4d444c41ee1699c Mon Sep 17 00:00:00 2001 From: Maryam Saeidi Date: Mon, 30 Sep 2024 21:44:21 +0200 Subject: [PATCH 4/4] Fix test --- x-pack/test/api_integration/apis/maps/maps_telemetry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/test/api_integration/apis/maps/maps_telemetry.ts b/x-pack/test/api_integration/apis/maps/maps_telemetry.ts index 4db33337429c1..3207fdbb739ef 100644 --- a/x-pack/test/api_integration/apis/maps/maps_telemetry.ts +++ b/x-pack/test/api_integration/apis/maps/maps_telemetry.ts @@ -37,7 +37,7 @@ export default function ({ getService }: FtrProviderContext) { } ); expect(geoPointFieldStats.count).to.be(55); - expect(geoPointFieldStats.index_count).to.be(11); + expect(geoPointFieldStats.index_count).to.be(12); const geoShapeFieldStats = apiResponse.cluster_stats.indices.mappings.field_types.find( (fieldStat: estypes.ClusterStatsFieldTypes) => {